Adding make_column_transformer #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed. |
|
My time is pretty limited at the moment but I really appreciate your
interest and help and will try to give this a careful look soon
|
|
No worries! Take your time. |
jnothman
reviewed
Dec 17, 2018
| @@ -2,6 +2,7 @@ | |||
| from collections import defaultdict as _defaultdict | |||
| import itertools as _itertools | |||
|
|
|||
| from sklearn.compose import ColumnTransformer as _ColumnTransformer | |||
There was a problem hiding this comment.
Let's make this code scikit-learn 0.19-compatible by importing this in make_column_transformer and skipping the corresponding tests in old versions.
| * if a step has estimators of mixed type, the step is named 'alt' | ||
| * if there are multiple steps of the same name using the above rules, | ||
| a suffix '-1', '-2', etc. is added. | ||
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave this issue a shot: #13
ColumnTransformer breaks from Pipeline and FeatureUnion's pattern by accepting a list of (encoder, 'column_name') tuples, instead of just a list of encoders. As a result, one question for this PR is whether searchgrid should pass a transformer name to ColumnTransformer.transformer that only contains the encoder class name, or if it should also include the column name. To be consistent with make_pipeline and make_union, I chose only the encoder class name.
@jnothman I'd love any comments or suggestions!